<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix absolute value warning in LocalizedStringsGtk.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=145919#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix absolute value warning in LocalizedStringsGtk.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=145919">bug 145919</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>There are two things wrong:
* Clang warns when passing a float to ::abs() because ::abs() will truncate the value, returning an int. If you are passing in a float, there's a high probability you wants to use std::abs() to receive a float instead.
* The current code casts the result of ::abs(), an int, to an int, which is pointless. We could remove the cast, but that would not avoid the clang warning. This is a very strange case that a compiler warning requires us to use an unnecessary cast.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>