<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Strict Equality on objects should only check that one of the two sides is an object."
href="https://bugs.webkit.org/show_bug.cgi?id=145992">bug 145992</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255137 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Strict Equality on objects should only check that one of the two sides is an object."
href="https://bugs.webkit.org/show_bug.cgi?id=145992#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Strict Equality on objects should only check that one of the two sides is an object."
href="https://bugs.webkit.org/show_bug.cgi?id=145992">bug 145992</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255137&action=diff" name="attach_255137" title="Patch">attachment 255137</a> <a href="attachment.cgi?id=255137&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255137&action=review">https://bugs.webkit.org/attachment.cgi?id=255137&action=review</a>
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1188
> + SpeculateCellOperand op1(this, node->child1());
> + JSValueOperand op2(this, node->child2());
> +
> + GPRReg op1GPR = op1.gpr();
> +#if USE(JSVALUE64)
> + GPRReg op2GPR = op2.gpr();
> +#else
> + GPRReg op2GPR = op2.payloadGPR();
> +#endif
> + DFG_TYPE_CHECK(
> + JSValueSource::unboxedCell(op1GPR), node->child1(), SpecObject, m_jit.branchIfNotObject(op1GPR));
> +
> + branchPtr(condition, op1GPR, op2GPR, taken);</span >
This appears wrong on 32-bit, since there you still have to test the tag word. Also, you could avoid the #if's by doing:
JSValueRegs op2Regs = op2.jsValueRegs();
GPRReg op2Payload = op2Regs.payloadGPR();
But that doesn't really help you with the tag issue on 32-bit.
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:1204
> + SpeculateCellOperand op1(this, node->child1());
> + JSValueOperand op2(this, node->child2());
> +
> + GPRReg op1GPR = op1.gpr();
> + GPRReg op2GPR = op2.payloadGPR();
> +
> + DFG_TYPE_CHECK(
> + JSValueSource::unboxedCell(op1GPR), node->child1(), SpecObject, m_jit.branchIfNotObject(op1GPR));
> +
> + GPRTemporary resultPayload(this, Reuse, op1);
> + GPRReg resultPayloadGPR = resultPayload.gpr();
> +
> + // At this point we know that we can perform a straight-forward equality comparison on pointer
> + // values because we are doing strict equality.
> + m_jit.compare32(MacroAssembler::Equal, op1GPR, op2GPR, resultPayloadGPR);
> + booleanResult(resultPayloadGPR, node);</span >
Ditto. Need a story for the tag word on 32-bit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>