<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - MediaSession: handle MediaEventTrackNext and MediaEventTrackPrevious events"
href="https://bugs.webkit.org/show_bug.cgi?id=146028#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - MediaSession: handle MediaEventTrackNext and MediaEventTrackPrevious events"
href="https://bugs.webkit.org/show_bug.cgi?id=146028">bug 146028</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146028#c4">comment #4</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=146028#c3">comment #3</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=254970&action=diff" name="attach_254970" title="Patch">attachment 254970</a> <a href="attachment.cgi?id=254970&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=254970&action=review">https://bugs.webkit.org/attachment.cgi?id=254970&action=review</a>
> >
> > > Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:67
> > > + if (session->currentState() == MediaSession::State::Active && session->kind() == "content")
> >
> > Generally it’s not good for an enum value to be a string literal at each
> > call site like this. It’s easy to have a typo and the compiler won’t catch
> > it. I suggest making constants for these special kind values somewhere, so
> > that we get a compile time error if we spell it wrong somewhere.
>
> Fixed. I didn't see us using many string constants in WebCore.</span >
Look at the newer enums exposed to JavaScript, for example TextTrackMode and TextTrackKind in TextTrack.idl/.cpp/.h</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>