<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn"
href="https://bugs.webkit.org/show_bug.cgi?id=146007#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn"
href="https://bugs.webkit.org/show_bug.cgi?id=146007">bug 146007</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254937&action=diff" name="attach_254937" title="Patch">attachment 254937</a> <a href="attachment.cgi?id=254937&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254937&action=review">https://bugs.webkit.org/attachment.cgi?id=254937&action=review</a>
For best compatibility across platforms would be much better to use WTF_ATTRIBUTE_PRINTF. Please do that.
<span class="quote">> Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:63
> +void __attribute__((format(printf, 2, 0))) pluginLogWithArguments(NPP instance, const char* format, va_list args)</span >
Oops, no this is wrong. Needs to use WTF_ATTRIBUTE_PRINTF</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>