<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - AX: WebKit exposes all Ruby Text as Unknown (Japanese EPUB accessibility blocker)"
href="https://bugs.webkit.org/show_bug.cgi?id=141303#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - AX: WebKit exposes all Ruby Text as Unknown (Japanese EPUB accessibility blocker)"
href="https://bugs.webkit.org/show_bug.cgi?id=141303">bug 141303</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=141303#c23">comment #23</a>)
<span class="quote">> > Moved tests to Mac
>
> This has not been communicated well, however this is not the right thing to
> do. Tests in platform/ subdirectories are hard to maintain, as it's
> impossible to figure out where to put expectations. E.g. would Mavericks WK2
> expectations for this test be in
> platform/mac/platform/mac-mavericks/platform/wk2, or in
> platform/mac/platform/wk2/platform/mac-mavericks, or in
> platform/mac-mavericks/platform/wk2, or somewhere else?
>
> Even barring that, a test that doesn't have any strong ties to a platform
> other than temporary implementation limitations should not be in a platform
> directory. Skipping the test in TestExpectations with an explanation of what
> needs to be implemented would provide a lot better visibility.</span >
In this case I think a platform test is better. The fix mostly labels ruby groups with subrole affiliations which only exist on the Mac. If gtk were to do something similar they would have a different result. So this patch does not exercise a common core experience, but rather focuses on the Mac details.
Since so much of the accessibility implementation is dependent on how the platform exposes attributes, there's many more platform tests that make sense than perhaps other areas of the code
Thanks</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>