<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Move cursor to corner and fix safari window size before running benchmark"
href="https://bugs.webkit.org/show_bug.cgi?id=145858#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Move cursor to corner and fix safari window size before running benchmark"
href="https://bugs.webkit.org/show_bug.cgi?id=145858">bug 145858</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254681&action=diff" name="attach_254681" title="Patch">attachment 254681</a> <a href="attachment.cgi?id=254681&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254681&action=review">https://bugs.webkit.org/attachment.cgi?id=254681&action=review</a>
<span class="quote">> Tools/ChangeLog:6
> + Reviewed by Ryosuke Niwa</span >
Was this really reviewed already? r? flag is set. Also, you are missing the period at the end of the sentence.
<span class="quote">> Tools/ChangeLog:7
> +</span >
Maybe a changelog to explain why this is needed and what you mean by fixing the Safari Window size?
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:53
> + def moveCursorToCorner(cls):</span >
Which corner? I could use something like "moveCursorToTopLeftCorner". Or a more generic "moveCursor(x, y)" that takes coordinates in parameters.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:25
> + try:</span >
We may want to move this code to a function with a clear that so that it is clearer what it does.
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:26
> + resolution = re.split('\s+', subprocess.check_output(['/usr/bin/defaults', 'read', 'com.apple.Safari', 'NSWindow Frame BrowserWindowFrame']).strip())[4:]</span >
Do we really need to call subprocesses for this. I believe there are pythonic ways of doing this (NSUserDefaults.standardUserDefaults()). Maybe this is useful:
<a href="http://www.macdevcenter.com/pub/a/mac/2003/01/31/pyobjc_one.html">http://www.macdevcenter.com/pub/a/mac/2003/01/31/pyobjc_one.html</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>