<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Explicitly keep track of active HTMLMediaElements in MediaSessions"
href="https://bugs.webkit.org/show_bug.cgi?id=145829">bug 145829</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #254619 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Explicitly keep track of active HTMLMediaElements in MediaSessions"
href="https://bugs.webkit.org/show_bug.cgi?id=145829#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Explicitly keep track of active HTMLMediaElements in MediaSessions"
href="https://bugs.webkit.org/show_bug.cgi?id=145829">bug 145829</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254619&action=diff" name="attach_254619" title="Patch (re-based)">attachment 254619</a> <a href="attachment.cgi?id=254619&action=edit" title="Patch (re-based)">[details]</a></span>
Patch (re-based)
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254619&action=review">https://bugs.webkit.org/attachment.cgi?id=254619&action=review</a>
<span class="quote">> Source/WebCore/html/HTMLMediaElement.cpp:2836
> + if (m_readyState == HAVE_CURRENT_DATA || m_readyState == HAVE_FUTURE_DATA) {
> + if (m_session)
> + m_session->addActiveMediaElement(*this);
> + }</span >
As we do elsewhere in this file, please include a comment with the text from the media session spec to explain why this is happening:
// <a href="https://mediasession.spec.whatwg.org/#activating-a-media-session">https://mediasession.spec.whatwg.org/#activating-a-media-session</a>
// 6.3. Activating a media session from a media element
// When the play() method on a media element is invoked and ...
// 1. Let media session be the value of media element’s current media session.
// 2. ...
etc.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>