<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Get rid of GetEditorCommandsForKeyEvent sync message"
href="https://bugs.webkit.org/show_bug.cgi?id=145598#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Get rid of GetEditorCommandsForKeyEvent sync message"
href="https://bugs.webkit.org/show_bug.cgi?id=145598">bug 145598</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254159&action=diff" name="attach_254159" title="Patch">attachment 254159</a> <a href="attachment.cgi?id=254159&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254159&action=review">https://bugs.webkit.org/attachment.cgi?id=254159&action=review</a>
<span class="quote">>>> Source/WebCore/dom/KeyboardEvent.cpp:233
>>> +#endif
>>
>> Why not use the m_handledByInputMethod boolean, like it's used for the Cocoa platform?
>
> Because we don't need to duplicate that, this is just a convenient method, to avoid having to get the platform event, check if it's null, and then get the boolean.</span >
I don't think using m_handledByInputMethod the same way it's used for PLATFORM(COCOA) && USE(APPKIT) is duplicating. I do think adding a new GTK-specific method that queries some state that a KeyboardEvent constructor could already determine is duplicating.
But given that this is a Web-exposed class, any platform-specific code is regrettable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>