<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkCache: Delete old cache versions"
href="https://bugs.webkit.org/show_bug.cgi?id=145800">bug 145800</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #254568 Flags</td>
<td>review+
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkCache: Delete old cache versions"
href="https://bugs.webkit.org/show_bug.cgi?id=145800#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkCache: Delete old cache versions"
href="https://bugs.webkit.org/show_bug.cgi?id=145800">bug 145800</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254568&action=diff" name="attach_254568" title="patch">attachment 254568</a> <a href="attachment.cgi?id=254568&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254568&action=review">https://bugs.webkit.org/attachment.cgi?id=254568&action=review</a>
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:62
> + struct dirent* dp;</span >
I think the "struct" is superfluous in C++.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:69
> + function(String(name), directoryEntryType(dp->d_type));</span >
Probably not a big deal for what you're using it for but this likely only works if the name only include latin1 characters. I think String::fromUTF8(name) would be more correct.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:94
> + struct stat fileInfo;</span >
struct is superfluous I believe.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:121
> + utimes(WebCore::fileSystemRepresentation(path).data(), 0);</span >
nullptr
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.h:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.</span >
Not commenting on this file as it seems it is the diff being confused.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:876
> + String versionString = subdirName.substring(strlen(versionDirectoryPrefix));</span >
We could use sizeof(versionDirectoryPrefix)-1 to resolve this at compile time instead of iterating over the string at runtime.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>