<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function"
href="https://bugs.webkit.org/show_bug.cgi?id=144955#c47">Comment # 47</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function"
href="https://bugs.webkit.org/show_bug.cgi?id=144955">bug 144955</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254239&action=diff" name="attach_254239" title="Patch">attachment 254239</a> <a href="attachment.cgi?id=254239&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254239&action=review">https://bugs.webkit.org/attachment.cgi?id=254239&action=review</a>
I can review (partially) this if it's limited to parser's change. In profiler part, I think I'm not a right reviewer.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:2023
> + bool doParseConditionalExpression = false;</span >
I think `shouldParseConditionalExpression` is better.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:2027
> + doParseConditionalExpression = !isArrowFunctionEmptyParamterList();</span >
In isArrowFunctionEmptyPararmeterList, we create SavePoint. So I think the above `createSavevPoint` and SavePoint are duplicate.
Could you change to the implementation that `isArrowFunctionEmptyParamterList` always restore the state?
With that implementation, the above SavePoint is not necessary.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>