<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value"
href="https://bugs.webkit.org/show_bug.cgi?id=141262#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value"
href="https://bugs.webkit.org/show_bug.cgi?id=141262">bug 141262</a>
from <span class="vcard"><a class="email" href="mailto:drousso@apple.com" title="drousso@apple.com">drousso@apple.com</a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254219&action=diff" name="attach_254219" title="Patch">attachment 254219</a> <a href="attachment.cgi?id=254219&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254219&action=review">https://bugs.webkit.org/attachment.cgi?id=254219&action=review</a>
<span class="quote">>> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:279
>> + nameMatchesValidPropertyExactly(name)
>
> Do we need to do anything special for properties that can have a "-webkit-" prefix or not? Like transform can, and some others.</span >
I tested this with a few different "-webkit-" prefixed properties and it worked correctly without any issues, so no. As far as I understand, the property name includes "-webkit-" so it will match with that in mind. If I had used canonicalName, then this would be a problem as it strips prefixes.
<span class="quote">>> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:542
>> + this._codeMirror.markText(start, end, {className: "invalid"});
>
> Will this marker get cleared when edits are made to make the value valid?</span >
Yes the marker is redrawn every time the editor is updated, so if the property is no longer invalid it will not draw.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>