<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add basic Media Session support to HTMLMediaElement"
href="https://bugs.webkit.org/show_bug.cgi?id=145581#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add basic Media Session support to HTMLMediaElement"
href="https://bugs.webkit.org/show_bug.cgi?id=145581">bug 145581</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254206&action=diff" name="attach_254206" title="Patch (speculative Windows build fix)">attachment 254206</a> <a href="attachment.cgi?id=254206&action=edit" title="Patch (speculative Windows build fix)">[details]</a></span>
Patch (speculative Windows build fix)
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254206&action=review">https://bugs.webkit.org/attachment.cgi?id=254206&action=review</a>
<span class="quote">> Source/WebCore/Modules/mediasession/HTMLMediaElementMediaSession.h:32
> +#include <wtf/text/WTFString.h></span >
Don’t need this.
<span class="quote">> Source/WebCore/Modules/mediasession/HTMLMediaElementMediaSession.h:36
> +class HTMLMediaElementMediaSession {</span >
What determines the interface and name of this class? It seems quite strange and I am not sure exactly what it’s for.
I might omit the second occurrence of the word “Media” but I’m not sure enough of context to know if that suggestion is OK.
<span class="quote">> Source/WebCore/Modules/mediasession/HTMLMediaElementMediaSession.h:42
> + static const String& kind(HTMLMediaElement* element) { return element->kind(); }
> + static void setKind(HTMLMediaElement* element, const String& kind) { return element->setKind(kind); }
> +
> + static MediaSession* session(HTMLMediaElement*, bool&);
> + static void setSession(HTMLMediaElement* element, MediaSession* session) { element->setSession(session); }</span >
These should all take HTMLMediaElement&, not HTMLMediaElement*.
<span class="quote">> Source/WebCore/html/HTMLMediaElement.h:422
> + void setSession(MediaSession*);</span >
Might want this to take RefPtr<MediaSession>&& instead, if callers are handing over ownership. If ownership is usually shared, then raw pointer is OK/better.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>