<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - streamline benchmark-runner browser"
href="https://bugs.webkit.org/show_bug.cgi?id=145582#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - streamline benchmark-runner browser"
href="https://bugs.webkit.org/show_bug.cgi?id=145582">bug 145582</a>
from <span class="vcard"><a class="email" href="mailto:slewis@apple.com" title="Stephanie Lewis <slewis@apple.com>"> <span class="fn">Stephanie Lewis</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=145582#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=254127&action=diff" name="attach_254127" title="patch">attachment 254127</a> <a href="attachment.cgi?id=254127&action=edit" title="patch">[details]</a></span>
> patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=254127&action=review">https://bugs.webkit.org/attachment.cgi?id=254127&action=review</a>
>
> > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:32
> > + process = subprocess.Popen(['open', '-a', appPath] + args)
> > + cls.launchCaffeinateForProcess(process.pid)
>
> Instead of having a helper function to launch caffinate, why don't we add a
> method e.g. launchProcessWithCaffinate that launches both the target process
> and caffeinate?
>
> > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:43
> > + subprocess.Popen(["/usr/bin/caffeinate", "-disw", str(pid)])
>
> Does caffeinate automatically terminate?</span >
Yeah Caffeinate takes the pid of a process to watch and terminates when the process terminates.
<span class="quote">>
> > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:39
> > + self.safariProcess = subprocess.Popen(args, env=env)
> > +
> > + OSXSafariDriver.launchCaffeinateForProcess(self.safariProcess.pid)
>
> That way, we can just call that function instead of Popen'ing and calling a
> separate helper function.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>