<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function"
href="https://bugs.webkit.org/show_bug.cgi?id=144955#c39">Comment # 39</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function"
href="https://bugs.webkit.org/show_bug.cgi?id=144955">bug 144955</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144955#c38">comment #38</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=144955#c37">comment #37</a>)
> > ERROR: Source/JavaScriptCore/parser/ParserTokens.h:79: enum members should
> > use InterCaps with an initial capital letter. [readability/enum_casing] [4]
> > ERROR: Source/JavaScriptCore/parser/Parser.h:752: The parameter name
> > "functionParseType" adds no information, so it should be removed.
> > [readability/parameter_name] [5]
>
> Please fix these!</span >
Not sure that I know how. Could you please suggest how to fix them?
1. Source/JavaScriptCore/parser/ParserTokens.h:79
I've added new value ARROWFUNCTION and followed the same style as all enums in this file <a href="http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/parser/ParserTokens.h#L75">http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/parser/ParserTokens.h#L75</a>
2. Source/JavaScriptCore/parser/Parser.h
In this file I've added new parameter with default value in exist function. I've used default value to decrease number of changes, so to default value I had to add name of the parameter.
template <class TreeBuilder> TreeStatement parseStatement(TreeBuilder&, const Identifier*& directive, unsigned* directiveLiteralLength = 0, !!!!FunctionParseType functionParseType = StandardFunctionParseType!!!!)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>