<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add stub implementation of MediaSession, part of Media Session spec"
href="https://bugs.webkit.org/show_bug.cgi?id=145530">bug 145530</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #254028 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add stub implementation of MediaSession, part of Media Session spec"
href="https://bugs.webkit.org/show_bug.cgi?id=145530#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add stub implementation of MediaSession, part of Media Session spec"
href="https://bugs.webkit.org/show_bug.cgi?id=145530">bug 145530</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254028&action=diff" name="attach_254028" title="Patch">attachment 254028</a> <a href="attachment.cgi?id=254028&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254028&action=review">https://bugs.webkit.org/attachment.cgi?id=254028&action=review</a>
If we have MediaSession.idl we need to have JSMediaSession.cpp and JSMediaSession.h.
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.h:32
> +#include <wtf/RefCounted.h></span >
If we include "MediaRemoteControls.h" it seems unlikely we need to include this also.
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.h:33
> +#include <wtf/RefPtr.h></span >
Ditto.
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.h:37
> +class MediaSession : public RefCounted<MediaSession> {</span >
I suggest marking this class final.
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.h:46
> + MediaSession(ScriptExecutionContext&, Kind);</span >
Does this compile? Does the bindings generator really turn those strings into MediaSession::Kind values?
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.h:47
> + virtual ~MediaSession();</span >
Why virtual? There doesn’t seem to be any polymorphism in this class, so it seems we should avoid marking it virtual.
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.h:50
> + MediaRemoteControls *controls() const { return m_controls.get(); }</span >
Wrong position of the * character here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>