<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Jpeg image export implementation for Canvas."
href="https://bugs.webkit.org/show_bug.cgi?id=145457#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] Jpeg image export implementation for Canvas."
href="https://bugs.webkit.org/show_bug.cgi?id=145457">bug 145457</a>
from <span class="vcard"><a class="email" href="mailto:hyuki.kim@samsung.com" title="KwangHyuk <hyuki.kim@samsung.com>"> <span class="fn">KwangHyuk</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=145457#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=253960&action=diff" name="attach_253960" title="Patch">attachment 253960</a> <a href="attachment.cgi?id=253960&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=253960&action=review">https://bugs.webkit.org/attachment.cgi?id=253960&action=review</a>
>
> > Source/WebCore/ChangeLog:20
> > + * platform/image-encoders/JPEGImageEncoder.cpp:
>
> You need to explain what is modified.
>
> > Source/WebCore/platform/MIMETypeRegistry.cpp:270
> > +#elif PLATFORM(EFL)
>
> Why can't we support image/tiff, image/bmp, image/ico ?
>
> Besides I think GTK and EFL have used cairo backend. Thus it might be good
> if you change this change as below,
>
> #elif PLATFORM(GTK)
> - supportedImageMIMETypesForEncoding->add("image/png");
> - supportedImageMIMETypesForEncoding->add("image/jpeg");
> supportedImageMIMETypesForEncoding->add("image/tiff");
> supportedImageMIMETypesForEncoding->add("image/bmp");
> supportedImageMIMETypesForEncoding->add("image/ico");
> #elif USE(CAIRO)
> supportedImageMIMETypesForEncoding->add("image/png");
> + supportedImageMIMETypesForEncoding->add("image/jpeg");
> + supportedImageMIMETypesForEncoding->add("image/png");
> #endif
> </span >
it's guarded by using #elif, therefore, it should be touched in order to re-use CAIRO definition.
This cairo definition might be for window port ?
<span class="quote">> > Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:4
> > + * This library is free software; you can redistribute it and/or
>
> Oops. LGPL.... Please use BSD !
>
> > Source/WebCore/platform/image-encoders/JPEGImageEncoder.cpp:126
> > + for (const unsigned char* rowEnd = pixel + offset + compressData.image_width * 4; pixel + offset < rowEnd;) {
>
> I think this change can influence on other ports. So you need to explain why
> you modify this code.</span >
ImageEncoder was not used by other port yet. :)
(In reply to <a href="show_bug.cgi?id=145457#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=253960&action=diff" name="attach_253960" title="Patch">attachment 253960</a> <a href="attachment.cgi?id=253960&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=253960&action=review">https://bugs.webkit.org/attachment.cgi?id=253960&action=review</a>
>
> > Source/WebCore/ChangeLog:20
> > + * platform/image-encoders/JPEGImageEncoder.cpp:
>
> You need to explain what is modified.
>
> > Source/WebCore/platform/MIMETypeRegistry.cpp:270
> > +#elif PLATFORM(EFL)
>
> Why can't we support image/tiff, image/bmp, image/ico ?
> </span >
Because this patch is just for adding jpeg export feature on Webkit EFL.
So, It's not necessary.
However, this can be considered as other new bug.
<span class="quote">> Besides I think GTK and EFL have used cairo backend. Thus it might be good
> if you change this change as below,
>
> #elif PLATFORM(GTK)
> - supportedImageMIMETypesForEncoding->add("image/png");
> - supportedImageMIMETypesForEncoding->add("image/jpeg");
> supportedImageMIMETypesForEncoding->add("image/tiff");
> supportedImageMIMETypesForEncoding->add("image/bmp");
> supportedImageMIMETypesForEncoding->add("image/ico");
> #elif USE(CAIRO)
> supportedImageMIMETypesForEncoding->add("image/png");
> + supportedImageMIMETypesForEncoding->add("image/jpeg");
> + supportedImageMIMETypesForEncoding->add("image/png");
> #endif
>
> > Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:4
> > + * This library is free software; you can redistribute it and/or
>
> Oops. LGPL.... Please use BSD !
> </span >
Thx, let me think about it.
<span class="quote">> > Source/WebCore/platform/image-encoders/JPEGImageEncoder.cpp:126
> > + for (const unsigned char* rowEnd = pixel + offset + compressData.image_width * 4; pixel + offset < rowEnd;) {
>
> I think this change can influence on other ports. So you need to explain why
> you modify this code.</span >
Unfortunately, it just generates clobbered error caused by setjmp and longjmp.
So, I just modified some code related with pixel variable.
However, the logic is same.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>