<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Selection in input gets removed when input is assigned to a new value."
href="https://bugs.webkit.org/show_bug.cgi?id=145430">bug 145430</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253888 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Selection in input gets removed when input is assigned to a new value."
href="https://bugs.webkit.org/show_bug.cgi?id=145430#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Selection in input gets removed when input is assigned to a new value."
href="https://bugs.webkit.org/show_bug.cgi?id=145430">bug 145430</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253888&action=diff" name="attach_253888" title="Patch">attachment 253888</a> <a href="attachment.cgi?id=253888&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253888&action=review">https://bugs.webkit.org/attachment.cgi?id=253888&action=review</a>
r- because this patch is missing a test.
I'm also worried that this change is not backwards compatible and may worsen the certain aspects of user interaction.
<span class="quote">> Source/WebCore/html/TextFieldInputType.cpp:129
> + if (Frame* frame = input->document()->frame()) {
> + start = frame->selection()->selection().start().offsetInContainerNode();
> + end = frame->selection()->selection().end().offsetInContainerNode();
> + }</span >
This is wrong. containerNode could be a div in the shadow DOM.
We should be using element().selectionStart() and element().selectionEnd() instead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>