<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works"
href="https://bugs.webkit.org/show_bug.cgi?id=143164#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works"
href="https://bugs.webkit.org/show_bug.cgi?id=143164">bug 143164</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143164#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=253801&action=diff" name="attach_253801" title="[PATCH] Proposed Fix">attachment 253801</a> <a href="attachment.cgi?id=253801&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
> [PATCH] Proposed Fix
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=253801&action=review">https://bugs.webkit.org/attachment.cgi?id=253801&action=review</a>
>
> r=me
>
> > Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js:425
> > + function didToggle()
>
> Reading the callback code, this will get called even if there was an error
> in the backend (passed: error, result, wasThrown). Should it only update if
> something actually changed?</span >
I thought about doing a "style.getPropertyValue" and seeing if the value changed, but decided against it.
Unknown side effects / errors could happen if someone overrides `CSSStyleDeclaration.prototype.setProperty` and ultimately still could have changed the property and so a refresh would still be useful. Always doing a refresh is the safe bet as long as we are using overridable APIs.
Technically setProperty can trigger an error naturally if invoked on a readonly style, but I don't think that should ever be the case for us.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>