<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - previousRootInlineBoxCandidatePosition & nextRootInlineBoxCandidatePosition FIXME to remove duplicate code"
href="https://bugs.webkit.org/show_bug.cgi?id=145285">bug 145285</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253551 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - previousRootInlineBoxCandidatePosition & nextRootInlineBoxCandidatePosition FIXME to remove duplicate code"
href="https://bugs.webkit.org/show_bug.cgi?id=145285#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - previousRootInlineBoxCandidatePosition & nextRootInlineBoxCandidatePosition FIXME to remove duplicate code"
href="https://bugs.webkit.org/show_bug.cgi?id=145285">bug 145285</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253551&action=diff" name="attach_253551" title="patch">attachment 253551</a> <a href="attachment.cgi?id=253551&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253551&action=review">https://bugs.webkit.org/attachment.cgi?id=253551&action=review</a>
Does seem like an improvement. But we should do a little more to make this even better.
<span class="quote">> Source/WebCore/editing/VisibleUnits.cpp:78
> +};</span >
Extraneous semicolon here. This should be an enum class, not a namespaced non-class enum.
<span class="quote">> Source/WebCore/editing/VisibleUnits.cpp:83
> + Node* leaf = direction == BoxCandidatePosition::Next ? nextLeafWithSameEditability(node, editableType) : previousLeafWithSameEditability(node, editableType);</span >
I think this would read better with a helper function to avoid the ? : every time.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>