<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - FTL is not working on Windows."
href="https://bugs.webkit.org/show_bug.cgi?id=145366#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - FTL is not working on Windows."
href="https://bugs.webkit.org/show_bug.cgi?id=145366">bug 145366</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=145366#c4">comment #4</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=145366#c3">comment #3</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=253683&action=diff" name="attach_253683" title="Patch">attachment 253683</a> <a href="attachment.cgi?id=253683&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=253683&action=review">https://bugs.webkit.org/attachment.cgi?id=253683&action=review</a>
> >
> > > Source/JavaScriptCore/ChangeLog:29
> > > + (JSC::FTL::canCompile): llvm does not support ArithPow on Windows.
> >
> > This is the wrong approach. You're preventing the compilation of an entire
> > function because of an intrinsic. Instead you should implement ArithPow on
> > Windows using a function call to a helper.
>
> Ok, thanks for reviewing :) I will look into this.</span >
Note that you could literally call the pow() function. It's possible that if you emit a call to an extern function named "pow" then LLVM might try to turn this into an intrinsic and then fail in the backend if the intrinsic is unsupported (I don't know if this is happening here, but I remember such a LLVM JIT bug with other math functions). One way to avoid this bug is to grab a pointer to the pow() function, and then emit a call to that pointer constant. We've done this a lot in other such thorny cases.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>