<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: debugging attributes for text markers"
href="https://bugs.webkit.org/show_bug.cgi?id=145283">bug 145283</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253542 Flags</td>
<td>
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: debugging attributes for text markers"
href="https://bugs.webkit.org/show_bug.cgi?id=145283#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: debugging attributes for text markers"
href="https://bugs.webkit.org/show_bug.cgi?id=145283">bug 145283</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253542&action=diff" name="attach_253542" title="patch">attachment 253542</a> <a href="attachment.cgi?id=253542&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253542&action=review">https://bugs.webkit.org/attachment.cgi?id=253542&action=review</a>
thanks
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3796
> + if ([attribute isEqualToString:@"AXTextMarkerDebugDescription"]) {</span >
can you put these into a separate method completely and can you put the logic in an ObjC method so that these can be called from within the debugger itself
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3797
> + VisiblePosition visiblePosition = [self visiblePositionForTextMarker:(textMarker)];</span >
i don't think the parens are necessary here
(textMarker)
<span class="quote">> Source/WebCore/dom/Text.cpp:231
> + result.appendLiteral("count=");</span >
this looks like it should be length instead of count</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>