<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:koivisto@iki.fi" title="Antti Koivisto <koivisto@iki.fi>"> <span class="fn">Antti Koivisto</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Layout Test http/tests/xmlhttprequest/range-test.html is failing"
href="https://bugs.webkit.org/show_bug.cgi?id=144682">bug 144682</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253328 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Layout Test http/tests/xmlhttprequest/range-test.html is failing"
href="https://bugs.webkit.org/show_bug.cgi?id=144682#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Layout Test http/tests/xmlhttprequest/range-test.html is failing"
href="https://bugs.webkit.org/show_bug.cgi?id=144682">bug 144682</a>
from <span class="vcard"><a class="email" href="mailto:koivisto@iki.fi" title="Antti Koivisto <koivisto@iki.fi>"> <span class="fn">Antti Koivisto</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253328&action=diff" name="attach_253328" title="Patch">attachment 253328</a> <a href="attachment.cgi?id=253328&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253328&action=review">https://bugs.webkit.org/attachment.cgi?id=253328&action=review</a>
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:112
> + String range = request.httpHeaderField(WebCore::HTTPHeaderName::Range);</span >
You could add a FIXME comment that explains that this implements minimal Range support where we don't parse the ranges and only the same exact range request will be served from the cache.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:114
> + if (range.isEmpty())
> + range = ASCIILiteral("No range");</span >
You should fix hashString() in NetworkCacheKey.cpp to work with null strings instead. if (string.isNull()) return should be sufficient.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:243
> + case 206: // Partial Content
> case 204: // No Content</span >
Please keep these in order.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>