<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: Implement ShareableResource for Soup and enable it for GTK platform"
href="https://bugs.webkit.org/show_bug.cgi?id=144380#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: Implement ShareableResource for Soup and enable it for GTK platform"
href="https://bugs.webkit.org/show_bug.cgi?id=144380">bug 144380</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144380#c13">comment #13</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=253310&action=diff" name="attach_253310" title="Try to fix IOS build">attachment 253310</a> <a href="attachment.cgi?id=253310&action=edit" title="Try to fix IOS build">[details]</a></span>
> Try to fix IOS build
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=253310&action=review">https://bugs.webkit.org/attachment.cgi?id=253310&action=review</a></span >
Thanks!
<span class="quote">> > Source/WebKit2/Platform/SharedMemory.h:88
> > + static RefPtr<SharedMemory> wrapMap(void*, size_t, int fileDescriptor);
>
> This should be #if'd for the platforms it is implemented only.</span >
hmm, right, I guess we should do the same for the create() that is mac only.
<span class="quote">> > Source/WebKit2/Shared/ShareableResource.cpp:85
> > +PassRefPtr<SharedBuffer> ShareableResource::sharedBuffer()
> > +{
> > + ref(); // Balanced by deref when SharedBuffer is deallocated.
>
> This is named like an accessor but does some non-accessor like ref tricks.
> Maybe wrapInSharedBuffer()?</span >
I thought about createSharedBuffer but didn't like it either, wrapInSharedBuffer() sounds good to me.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>