<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix the incorrectness that AtomicString could have symbolic StringImpl"
href="https://bugs.webkit.org/show_bug.cgi?id=145002">145002</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Fix the incorrectness that AtomicString could have symbolic StringImpl
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>528+ (Nightly build)
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Web Template Framework
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>utatane.tea@gmail.com
</td>
</tr></table>
<p>
<div>
<pre>In issue 144848, AtomicStringImpl's incorrectness is resolved.
But AtomicString's incorrectness still remains.
There are several plans.
1. Introduce UniquedString, AtomicString, SymbolString and replace the current AtomicString with UniquedString
The simplest plan. Introduce UniquedString and SymbolString as the same to UniquedStringImpl and SymbolImpl.
And replace the current AtomicString use with UniquedString.
Pros:
+ Simple, easy.
Cons:
+ Introduce more and more classes for strings :(
2. Drop AtomicString and use RefPtr<UniquedStringImpl> / Ref<UniquedStringImpl> directly
Drop the AtomicString use cases completely and use RefPtr<UniquedStringImpl> / Ref<UniquedStringImpl> instead.
Pros:
+ We can drop the class for strings! (AtomicString)
Cons:
+ Since there's code using `operator==` for AtomicString, rewriting is not mechanical. (We need to consider about PassRefPtr<UniquedStringImpl>...)
+ WTFString remains.
In both, IDL change is involved.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>