<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process"
href="https://bugs.webkit.org/show_bug.cgi?id=144738#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process"
href="https://bugs.webkit.org/show_bug.cgi?id=144738">bug 144738</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144738#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=253103&action=diff" name="attach_253103" title="Patch">attachment 253103</a> <a href="attachment.cgi?id=253103&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=253103&action=review">https://bugs.webkit.org/attachment.cgi?id=253103&action=review</a>
>
> > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:-210
> > + if (m_handle && !m_didConvertHandleToDownload)
> > m_handle->setClient(nullptr);
> > - m_handle = nullptr;
> > - }
>
> This is not right for Mac. On the Mac, the download is not a
> ResourceHandleClient, so the client pointer is invalid once the handle is
> converted to a download.
>
> Would it be possible to follow Mac design, and not use a
> ResourceHandleClient for downloading? This is quite confusing, I certainly
> didn't expect such a difference when making the change.</span >
What's wrong using a ResourceHandleClient for downloads? We would use libsoup directly for downloading, but we would probably ended up duplicating the ResourceHandle code.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>