<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] WebSocket platform part is not implemented."
href="https://bugs.webkit.org/show_bug.cgi?id=144628#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] WebSocket platform part is not implemented."
href="https://bugs.webkit.org/show_bug.cgi?id=144628">bug 144628</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144628#c19">comment #19</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=253030&action=diff" name="attach_253030" title="Patch">attachment 253030</a> <a href="attachment.cgi?id=253030&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=253030&action=review">https://bugs.webkit.org/attachment.cgi?id=253030&action=review</a>
>
> > Source/WebCore/platform/network/curl/SocketStreamHandle.h:92
> > + SocketData(std::unique_ptr<char[]>&& source, int length)
> > + {
> > + data = WTF::move(source);
> > + size = length;
> > + }
>
> Really irritating that we have to do this to work around a bug in MSVC, but
> I’m pretty sure that is indeed what we are doing, working around a bug. Two
> separate related bugs, I guess.
> </span >
Thanks for reviewing :) I can try to remember to revisit this code when we move to the next MSVC version.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>