<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] WebSocket platform part is not implemented."
href="https://bugs.webkit.org/show_bug.cgi?id=144628#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] WebSocket platform part is not implemented."
href="https://bugs.webkit.org/show_bug.cgi?id=144628">bug 144628</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144628#c13">comment #13</a>)
<span class="quote">> > MSVC didn't want to convert this, I got the error:
> >
> > error C2664: 'std::unique_ptr<const char
> > [],std::default_delete<_Ty>>::unique_ptr(const
> > std::unique_ptr<_Ty,std::default_delete<_Ty>> &)' :
> > cannot convert argument 1 from 'std::unique_ptr<char
> > [],std::default_delete<_Ty>>' to 'std::unique_ptr<const char
> > [],std::default_delete<_Ty>> &&'
> If this really is a bug in MSVC, could you use const_cast to add const
> instead of taking it away? That would be nicer.
> > I had to add a SocketData constructor since m_sendData.append(SocketData {
> > WTF::move(copy), length }) didn't compile with MSVC. The error I got was:
> >
> > error C2440 : '<function-style-cast>' : cannot convert from
> > 'initializer-list' to 'WebCore::SocketStreamHandle::SocketData'
> > 1> No constructor could take the source type, or constructor
> > overload resolution was ambiguous
> Does it work to call the constructor without any initializer-list? (no {})</span >
Thanks for looking into this :)
I removed the const modifier from the unique_ptr member in the last patch to avoid all the casting. I hope this is acceptable :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>