<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560">bug 144560</a>
from <span class="vcard"><a class="email" href="mailto:philip.chimento@gmail.com" title="Philip Chimento <philip.chimento@gmail.com>"> <span class="fn">Philip Chimento</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144560#c9">comment #9</a>)
Thanks, I'll update the patch with these comments.
<span class="quote">> Most of those OS(DARWIN) -> PLATFORM(COCOA) changes don’t seem right to me.
> I added comments about a few of them. Others sound comment on the use inside
> WebKit2.
>
> > Source/WTF/wtf/WorkQueue.h:39
> > -#if OS(DARWIN)
> > +#if PLATFORM(COCOA)
> > #include <dispatch/dispatch.h>
> > #endif
>
> It’s a little sad to go in this direction. Better to use the OS ones than
> the PLATFORM ones whenever possible.</span >
My previous version had #if OS(DARWIN) && !PLATFORM(GTK) everywhere. That works for me as well, but everyone should agree on one and stick with it ;-)
I do prefer Csaba's suggestion of PLATFORM(COCOA) because the way I think of "platform" it should use mainly the same dependencies no matter what OS it's compiled on. For me, differences between the OSs should limit themselves to e.g. system calls (an example of what I mean is <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK][SOUP] Web and Network processes don't know how to get memory size on OSX"
href="show_bug.cgi?id=144554">https://bugs.webkit.org/show_bug.cgi?id=144554</a>). But, I'm happy to go either way with this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>