<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Delegates scrolling by wheel event should be work within contents area."
href="https://bugs.webkit.org/show_bug.cgi?id=139757#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Delegates scrolling by wheel event should be work within contents area."
href="https://bugs.webkit.org/show_bug.cgi?id=139757">bug 139757</a>
from <span class="vcard"><a class="email" href="mailto:sh53.lee@samsung.com" title="Sanghyup Lee <sh53.lee@samsung.com>"> <span class="fn">Sanghyup Lee</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=139757#c18">comment #18</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=252790&action=diff" name="attach_252790" title="Patch">attachment 252790</a> <a href="attachment.cgi?id=252790&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=252790&action=review">https://bugs.webkit.org/attachment.cgi?id=252790&action=review</a>
>
> > Source/WebCore/page/FrameView.cpp:4460
> > IntPoint oldPosition = scrollPosition();
> > IntSize newOffset = IntSize(offset.width() - wheelEvent.deltaX(), offset.height() - wheelEvent.deltaY());
> > if (offset != newOffset) {
> > - ScrollView::scrollTo(newOffset);
> > + setScrollOffset(IntPoint(newOffset));
> > scrollPositionChanged(oldPosition, scrollPosition());
> > didChangeScrollOffset();
> > }
>
> With this patch as posted for review, scrollPositionChanged and
> didChangeScrollOffset will be called twice. Instead of these 8 lines of
> code, I suggest this one line of code:
>
> setScrollOffset(scrollPosition() + IntSize(-wheelEvent.deltaX(),
> -wheelEvent.deltaY()));
>
> I didn’t look at the failure on Mac; the one to that is running tests in
> this mode returned a failure.</span >
Thank you for your kind review and I'll fix it.
As far as I know, delegate scrolling is for WK2.
So Can I skip this test on Mac?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>