<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Use preview view controller from WebKitSystemInterface."
href="https://bugs.webkit.org/show_bug.cgi?id=144836">bug 144836</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252821 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use preview view controller from WebKitSystemInterface."
href="https://bugs.webkit.org/show_bug.cgi?id=144836#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use preview view controller from WebKitSystemInterface."
href="https://bugs.webkit.org/show_bug.cgi?id=144836">bug 144836</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252821&action=diff" name="attach_252821" title="New patch.">attachment 252821</a> <a href="attachment.cgi?id=252821&action=edit" title="New patch.">[details]</a></span>
New patch.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252821&action=review">https://bugs.webkit.org/attachment.cgi?id=252821&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:23
> + (-[WKContentView previewViewControllerForPosition:inSourceView:]): : For client that doesn't provide</span >
: :
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:131
> +@property (nonatomic, getter=_allowsLinkPreview, setter=_setAllowsLinkPreview:) BOOL _allowsLinkPreview;</span >
No need for a custom getter here since it’s the same as the property name. Needs WK_AVAILABLE(NA, WK_IOS_TBA).
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:211
> +
> +- (void)_registerPreviewInWindow:(UIWindow *)window;
> +- (void)_unregisterPreviewInWindow:(UIWindow *)window;</span >
Weird to have a newline before but not after.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>