<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use preview view controller from WebKitSystemInterface."
href="https://bugs.webkit.org/show_bug.cgi?id=144836#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use preview view controller from WebKitSystemInterface."
href="https://bugs.webkit.org/show_bug.cgi?id=144836">bug 144836</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252791&action=diff" name="attach_252791" title="Patch.">attachment 252791</a> <a href="attachment.cgi?id=252791&action=edit" title="Patch.">[details]</a></span>
Patch.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252791&action=review">https://bugs.webkit.org/attachment.cgi?id=252791&action=review</a>
This looks OK to me. I am surprised that the new property is being introduced as API right away rather than SPI. I’d like someone else from Apple to review this aspect.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:235
> +@property (nonatomic) BOOL allowsLinkPreview;</span >
This needs WK_AVAILABLE(NA, WK_IOS_TBA).
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:45
> +#if USE(APPLE_INTERNAL_SDK)
> +#import <WebKitAdditions/LinkPreviewDefines.h>
> +#endif</span >
These lines should move to a separate paragraph, after the non-conditional imports.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3116
> + _previewGestureRecognizer.clear();</span >
We seem to prefer “= nil” to clear().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>