<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Some macros need to be defined/undefined, rather than ON/OFF"
href="https://bugs.webkit.org/show_bug.cgi?id=144845#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Some macros need to be defined/undefined, rather than ON/OFF"
href="https://bugs.webkit.org/show_bug.cgi?id=144845">bug 144845</a>
from <span class="vcard"><a class="email" href="mailto:philip.chimento@gmail.com" title="Philip Chimento <philip.chimento@gmail.com>"> <span class="fn">Philip Chimento</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144845#c3">comment #3</a>)
<span class="quote">> Thanks for your patches. I'd like to change the code to be more robust to
> this, checking values rather than definitions. But I don't see value in
> fighting that fight in npapi.h, so this is probably the best approach. Let's
> see what Martin thinks. There should for sure be a warning comment, though,
> or someone will revert this patch in passing as a cleanup.</span >
Sure thing. I did kind of assume that npapi.h was off limits. I've added a warning comment.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>