<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API"
href="https://bugs.webkit.org/show_bug.cgi?id=144748#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API"
href="https://bugs.webkit.org/show_bug.cgi?id=144748">bug 144748</a>
from <span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252594&action=diff" name="attach_252594" title="Patch">attachment 252594</a> <a href="attachment.cgi?id=252594&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252594&action=review">https://bugs.webkit.org/attachment.cgi?id=252594&action=review</a>
That's a r=me. Another WebKitGtk reviewer must approve the new API though
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060
> + if (currentValue == allowed)</span >
currentValue is not really needed. I think using the function call directly is explicit enough.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>