<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix internal build configuration issues"
href="https://bugs.webkit.org/show_bug.cgi?id=144762">bug 144762</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252655 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix internal build configuration issues"
href="https://bugs.webkit.org/show_bug.cgi?id=144762#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix internal build configuration issues"
href="https://bugs.webkit.org/show_bug.cgi?id=144762">bug 144762</a>
from <span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252655&action=diff" name="attach_252655" title="More bug fixes (thanks Joe!)">attachment 252655</a> <a href="attachment.cgi?id=252655&action=edit" title="More bug fixes (thanks Joe!)">[details]</a></span>
More bug fixes (thanks Joe!)
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252655&action=review">https://bugs.webkit.org/attachment.cgi?id=252655&action=review</a>
Please make corrections above and post a new patch.
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:30
> +HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport ForwardingHeaders $(MAYBE_HEADER_SEARCH_PATHS) $(SRCROOT)/../../Source/JavaScriptCore/icu;
> +MAYBE_HEADER_SEARCH_PATHS[sdk=iphone*] = $(SDKROOT)/usr/local/include $(SDKROOT)/usr/local/include/WebCoreTestSupport $(SRCROOT)/../../Source/WebKit2/Platform/spi/ios;</span >
Please rename MAYBE_HEADER_SEARCH_PATHS to PLATFORM_HEADER_SEARCH_PATHS. I think "PLATFORM" is more descriptive than "MAYBE" here.
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:31
> +MAYBE_HEADER_SEARCH_PATHS[sdk=macosx*] = mac/InternalHeaders $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport $(BUILT_PRODUCTS_DIR)/usr/local/include $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport ForwardingHeaders $(SRCROOT)/../../Source/JavaScriptCore/icu;</span >
This doesn't need to be this long; it's duplicating paths in HEADER_SEARCH_PATHS:
PLATFORM_HEADER_SEARCH_PATHS[sdk=macosx*] = mac/InternalHeaders $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport;
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:31
> +MACOSX_DEPLOYMENT_TARGET[sdk=macosx*] = $(MACOSX_DEPLOYMENT_TARGET_$(PLATFORM_NAME));</span >
It's redundant to use $(PLATFORM_NAME) here when [sdk=macosx*] will ensure that PLATFORM_NAME=macosx. I would just say:
MACOSX_DEPLOYMENT_TARGET[sdk=macosx*] = $(MACOSX_DEPLOYMENT_TARGET_macosx);
And, in fact, you can merge this line with the next line to make:
MACOSX_DEPLOYMENT_TARGET[sdk=macosx*] = $(MACOSX_DEPLOYMENT_TARGET_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:37
> +WEBKIT_SYSTEM_INTERFACE_LIBRARY[sdk=macosx*] = $(WEBKIT_SYSTEM_INTERFACE_LIBRARY_$(PLATFORM_NAME));</span >
Similarly here you can merge this line with the next line:
WEBKIT_SYSTEM_INTERFACE_LIBRARY[sdk=macosx*] = $(WEBKIT_SYSTEM_INTERFACE_LIBRARY_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:30
> +OTHER_LDFLAGS = $(MAYBE_OTHER_LDFLAGS) $(ASAN_OTHER_LDFLAGS);</span >
Please use PLATFORM_OTHER_LDFLAGS instead of MAYBE_OTHER_LDFLAGS.
<span class="quote">> Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:31
> +MAYBE_OTHER_LDFLAGS[sdk=iphone*] = -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS) $(ASAN_OTHER_LDFLAGS);</span >
No need to include $(ASAN_OTHER_LDFLAGS) here as it's redundant with OTHER_LDFLAGS.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>