<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Re-enable Quartz backend on cmake build system"
href="https://bugs.webkit.org/show_bug.cgi?id=144561#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Re-enable Quartz backend on cmake build system"
href="https://bugs.webkit.org/show_bug.cgi?id=144561">bug 144561</a>
from <span class="vcard"><a class="email" href="mailto:philip.chimento@gmail.com" title="Philip Chimento <philip.chimento@gmail.com>"> <span class="fn">Philip Chimento</span></a>
</span></b>
<pre><span class="quote">> Is this patch for master?</span >
It is for 2.8.0. If I have some time later then I can try to make a patch for master, but as I mentioned on one of the other bugs it is fairly inconvenient for me to test it due to the uncommon platform; any help that would make it easier for me is appreciated.
<span class="quote">> We expose variables to the build using SET_AND_EXPOSE_TO_BUILD now.</span >
Doesn't exist in 2.8 AFACIT, so I'll leave it like this for the 2.8 patch.
<span class="quote">> I don't think the help message should mention Quartz until the port is fully functional.</span >
After the spate of patches that I filed on Sunday, the port should be fully functional; at least it works for me. So I'd prefer to keep it in.
<span class="quote">> > Here you should give an error, because we want the build to produce errors
> > instead of silently disabling things now.</span >
>
<span class="quote">> Well, it should be an error indeed, but in PlatformGTK.cmake, not there. The find
> module shouldn't have anything to do with which features to enable: it should just
> find things. It should export a variable, say GTK_QUARTZ_FOUND, to indicate if it is
> available. Then in PlatformGTK.cmake, if ENABLE_QUARTZ_TARGET is set but
> GTK_QUARTZ_FOUND is not, the build should fail using message(FATAL_ERROR ...).</span >
>
<span class="quote">> But this patch is only copying the existing format of FindGTK3.cmake, which touches
> both ENABLE_X11_TARGET and ENABLE_WAYLAND_TARGET currently.</span >
So, should I make this give an error now? Or leave it the way it is for consistency with the existing code of FindGTK3.cmake and let it be fixed by #144613.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>