<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [X11] Add XUniquePtr and XUniqueResource to automatically free X resources"
href="https://bugs.webkit.org/show_bug.cgi?id=144521#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [X11] Add XUniquePtr and XUniqueResource to automatically free X resources"
href="https://bugs.webkit.org/show_bug.cgi?id=144521">bug 144521</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252487&action=diff" name="attach_252487" title="Try to fix EFL build">attachment 252487</a> <a href="attachment.cgi?id=252487&action=edit" title="Try to fix EFL build">[details]</a></span>
Try to fix EFL build
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252487&action=review">https://bugs.webkit.org/attachment.cgi?id=252487&action=review</a>
<span class="quote">>>> Source/WebCore/PlatformEfl.cmake:200
>>> + platform/graphics/x11/XUnique.cpp
>>
>> Consider splitting XUnique.h into XUniquePtr.h and XUniqueResource.h, and renaming XUnique.cpp to XUniqueResource.cpp.
>
> Why? I think it's quite simple and reduces the amount of header includes.</span >
Because over the lifetime of the WebKit project we’ve found that using a separate header for each class is a better pattern. Headers that have sets of classes might make sense when you are writing the code, but they can be frustrating later when reading and maintaining the code; a more mechanical rule is easier to understand and works better for someone who thinks slightly differently than the original author about categories.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>