<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - New force-related DOM events should fire in WK1 views"
href="https://bugs.webkit.org/show_bug.cgi?id=144663">bug 144663</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252540 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - New force-related DOM events should fire in WK1 views"
href="https://bugs.webkit.org/show_bug.cgi?id=144663#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - New force-related DOM events should fire in WK1 views"
href="https://bugs.webkit.org/show_bug.cgi?id=144663">bug 144663</a>
from <span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252540&action=diff" name="attach_252540" title="Patch">attachment 252540</a> <a href="attachment.cgi?id=252540&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252540&action=review">https://bugs.webkit.org/attachment.cgi?id=252540&action=review</a>
<span class="quote">> Source/WebCore/page/mac/EventHandlerMac.mm:124
> currentNSEventSlot() = m_savedCurrentEvent;
> + correspondingPressureEventSlot() = nil;</span >
I would follow the pattern we have here and keep a stack of corresponding events.
<span class="quote">> Source/WebKit/mac/WebView/WebHTMLView.mm:4093
> + NSEvent *lastPressureEvent = [[self _webView] _pressureEvent];
> + if (event == lastPressureEvent)
> + return;</span >
Is this necessary? It seems like it can't happen.
<span class="quote">> Source/WebKit/mac/WebView/WebViewData.h:178
> + NSEvent *pressureEvent;</span >
This should be a RetainPtr. You can probably get rid of the helpers when you make this change.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>