<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax"
href="https://bugs.webkit.org/show_bug.cgi?id=140855#c132">Comment # 132</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax"
href="https://bugs.webkit.org/show_bug.cgi?id=140855">bug 140855</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252416&action=diff" name="attach_252416" title="Patch">attachment 252416</a> <a href="attachment.cgi?id=252416&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252416&action=review">https://bugs.webkit.org/attachment.cgi?id=252416&action=review</a>
I've added separate patch with fixes.
<span class="quote">>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1541
>> +#if ENABLE(ES6_ARROWFUNCTION_SYNTAX)
>
> Why do you need this guard? I recommend adding the arraowFunctionStructure() to JSGlobalObject unconditionally.</span >
Done
<span class="quote">>> Source/JavaScriptCore/dfg/DFGCapabilities.cpp:234
>> + case op_new_arrow_func_exp: // Fixme: Arrow function cann't be inline as the common function because it has lexicaly bind this/arguments and etc. and arrow function has to have its own compile and inline approach.
>
> I don't buy this comment at all. Sounds like either there is a horrible bug, or you could just allow it.</span >
Implemented.
<span class="quote">>> Source/JavaScriptCore/dfg/DFGStructureRegistrationPhase.cpp:134
>> +#if ENABLE(ES6_ARROWFUNCTION_SYNTAX)
>
> Ditto to my previous. Get rid of this guard.</span >
Done.
<span class="quote">>> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2992
>> + void compileNewArrowFunction()
>
> If you're going to implement it in the FTL, then also implement it in DFG.</span >
I've implemented it in DFG.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>