<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - New stress/new-largeish-contiguous-array-with-size.js fails on 32 bit platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=144677#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - New stress/new-largeish-contiguous-array-with-size.js fails on 32 bit platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=144677">bug 144677</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144677#c0">comment #0</a>)
<span class="quote">> New stress/new-largeish-contiguous-array-with-size.js
> introduced in <a href="https://trac.webkit.org/changeset/183847">https://trac.webkit.org/changeset/183847</a>
> and fails on 32 bit platforms.
>
> It failed once on GTK 32 bit bot:
> -
> <a href="https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/52461">https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/52461</a>
> - stress/new-largeish-contiguous-array-with-size.js.default: Exception:
> Error: heap too big before forced GC: 108104384
>
> It fails persistently on EFL 32 bit ARM bots since it is introduced:
> - stress/new-largeish-contiguous-array-with-size.js.default: Exception:
> Error: heap too big before forced GC: 119708840
> - stress/new-largeish-contiguous-array-with-size.js.default: Exception:
> Error: heap too big before forced GC: 124108928
> - stress/new-largeish-contiguous-array-with-size.js.default: Exception:
> Error: heap too big before forced GC: 129308808
> - stress/new-largeish-contiguous-array-with-size.js.default: Exception:
> Error: heap too big before forced GC: 120108656
> ...
>
> Can it be a real bug or a bug in the test?</span >
I think that the test might be wrong. I was assuming that 100MB is the largest that our minimum heap size would get. But I'm wrong:
static inline size_t minHeapSize(HeapType heapType, size_t ramSize)
{
if (heapType == LargeHeap)
return min(largeHeapSize, ramSize / 4);
return smallHeapSize;
}
So, if you're on a machine with tons of heap, we'll be happy to give you 1/4 RAM headroom. This actually seems super sketchy anyways and maybe we should fix that - but for now it means that as written, my test is incorrect.
I'll investigate.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>