<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebBackForwardList::backForwardListState(filter) can set the currentIndex to a really large number"
href="https://bugs.webkit.org/show_bug.cgi?id=144666">144666</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>WebBackForwardList::backForwardListState(filter) can set the currentIndex to a really large number
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>528+ (Nightly build)
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebKit2
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>adachan@apple.com
</td>
</tr></table>
<p>
<div>
<pre>If the currentIndex is 0 and the first item gets filtered out, we'll end up decrementing currentIndex (which is bad as it's unsigned).
See the code here:
for (size_t i = 0; i < m_entries.size(); ++i) {
auto& entry = *m_entries[i];
if (filter && !filter(entry)) {
if (backForwardListState.currentIndex && i <= backForwardListState.currentIndex.value())
--backForwardListState.currentIndex.value();
continue;
}
backForwardListState.items.append(entry.itemState());
}
Seems like we should check whether the currentIndex > 0 before decrementing it. And if the list items end up being all filtered out, then the currentIndex should be set to the "uninitialized" value.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>