<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL] Move EGLDisplay handling to PlatformDisplay"
href="https://bugs.webkit.org/show_bug.cgi?id=144685#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL] Move EGLDisplay handling to PlatformDisplay"
href="https://bugs.webkit.org/show_bug.cgi?id=144685">bug 144685</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144685#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=252470&action=diff" name="attach_252470" title="Try to fix EFL build">attachment 252470</a> <a href="attachment.cgi?id=252470&action=edit" title="Try to fix EFL build">[details]</a></span>
> Try to fix EFL build
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=252470&action=review">https://bugs.webkit.org/attachment.cgi?id=252470&action=review</a>
>
> > Source/WebCore/platform/graphics/PlatformDisplay.cpp:139
> > +#if USE(OPENGL_ES_2)
> > + static const EGLenum eglAPIVersion = EGL_OPENGL_ES_API;
> > +#else
> > + static const EGLenum eglAPIVersion = EGL_OPENGL_API;
> > +#endif
> > + if (eglBindAPI(eglAPIVersion) == EGL_FALSE) {
> > + LOG_ERROR("Failed to set EGL API(%d).", eglGetError());
> > + terminateEGLDisplay();
> > + return;
> > + }
>
> This needs to be called once per program, not once per display. Perhaps you
> could surround this with std::once.</span >
Display is already a single instance, so this will be called only once per display, per process.
<span class="quote">> > Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp:153
> > - m_glxPixmap = glXCreateGLXPixmap(m_sharedDisplay, visualInfo.get(), m_pixmap);
> > + m_glxPixmap = glXCreateGLXPixmap(X11Helper::nativeDisplay(), visualInfo.get(), m_pixmap);
>
> This is GLX-related, so perhaps you could update the bug title and ChangeLog
> slightly?</span >
But nothing has actually changed here, I can add and remove PlatformDisplay from GLDefs.h</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>