<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL] Move EGLDisplay handling to PlatformDisplay and remove PlatformDisplay definition from GLDefs.h"
href="https://bugs.webkit.org/show_bug.cgi?id=144685#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EGL] Move EGLDisplay handling to PlatformDisplay and remove PlatformDisplay definition from GLDefs.h"
href="https://bugs.webkit.org/show_bug.cgi?id=144685">bug 144685</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144685#c5">comment #5</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=144685#c4">comment #4</a>)
> > (In reply to <a href="show_bug.cgi?id=144685#c3">comment #3</a>)
> > > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=252470&action=diff" name="attach_252470" title="Try to fix EFL build">attachment 252470</a> <a href="attachment.cgi?id=252470&action=edit" title="Try to fix EFL build">[details]</a></span>
> > > Try to fix EFL build
> > >
> > > View in context:
> > > <a href="https://bugs.webkit.org/attachment.cgi?id=252470&action=review">https://bugs.webkit.org/attachment.cgi?id=252470&action=review</a>
> > >
> > > > Source/WebCore/platform/graphics/PlatformDisplay.cpp:139
> > > > +#if USE(OPENGL_ES_2)
> > > > + static const EGLenum eglAPIVersion = EGL_OPENGL_ES_API;
> > > > +#else
> > > > + static const EGLenum eglAPIVersion = EGL_OPENGL_API;
> > > > +#endif
> > > > + if (eglBindAPI(eglAPIVersion) == EGL_FALSE) {
> > > > + LOG_ERROR("Failed to set EGL API(%d).", eglGetError());
> > > > + terminateEGLDisplay();
> > > > + return;
> > > > + }
> > >
> > > This needs to be called once per program, not once per display. Perhaps you
> > > could surround this with std::once.
> >
> > Display is already a single instance, so this will be called only once per
> > display, per process.
>
> eglBindAPI isn't supposed to be called once per-display. I supposed to be
> called once.</span >
There's only one display, so it will be called once. Anyway, I've moved the egl initializations repeated in several places here, so if it was wrong it can be fixed in a follow up patch, this patch shouldn't change any behaviour. But I insist, this is called only once per process.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>