<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - New force-related DOM events should fire in WK1 views"
href="https://bugs.webkit.org/show_bug.cgi?id=144663#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - New force-related DOM events should fire in WK1 views"
href="https://bugs.webkit.org/show_bug.cgi?id=144663">bug 144663</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144663#c6">comment #6</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=144663#c5">comment #5</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=252527&action=diff" name="attach_252527" title="Patch">attachment 252527</a> <a href="attachment.cgi?id=252527&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=252527&action=review">https://bugs.webkit.org/attachment.cgi?id=252527&action=review</a>
> >
> > > Source/WebCore/page/mac/EventHandlerMac.mm:86
> > > + static NeverDestroyed<RetainPtr<NSEvent>> event;
> >
> > Is it really right for this to be stored between views? That seems weird.
> >
>
> Hmm, maybe not. I was copying what's done for currentNSEventSlot(). I think
> it makes as much sense in this new case as it did in the old, but I'm a
> little unsure here.</span >
It's OK to keep a "current" event globally, because the relevant parts of WebKit are single-threaded, and a "current" event will get cleared when it's done (I assume). But keeping a "last" event, that lives beyond its own handling, seems wrong in the multi-view case.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>