<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: IOChannel operations are not sent to the right thread"
href="https://bugs.webkit.org/show_bug.cgi?id=144542">bug 144542</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252264 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: IOChannel operations are not sent to the right thread"
href="https://bugs.webkit.org/show_bug.cgi?id=144542#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: IOChannel operations are not sent to the right thread"
href="https://bugs.webkit.org/show_bug.cgi?id=144542">bug 144542</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252264&action=diff" name="attach_252264" title="Patch">attachment 252264</a> <a href="attachment.cgi?id=252264&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252264&action=review">https://bugs.webkit.org/attachment.cgi?id=252264&action=review</a>
Too bad all this code is boilerplate and repeated three times. Seems like instead you could have a helper function and that takes a single lambda to abstract away which of the three IOChannel functions is called.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:162
> + GMainLoopSource::scheduleAndDeleteOnDestroy("[WebKit] IOChannel::read", std::function<void()>([channel, offset, size, completionHandler] {
> + channel->read(offset, size, completionHandler);
> + }), G_PRIORITY_DEFAULT, nullptr, g_main_context_default());</span >
Why is that typecast to std::function needed? Should just work without it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>