<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Re-enable Quartz backend on cmake build system"
href="https://bugs.webkit.org/show_bug.cgi?id=144561">bug 144561</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>mcatanzaro@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Re-enable Quartz backend on cmake build system"
href="https://bugs.webkit.org/show_bug.cgi?id=144561#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Re-enable Quartz backend on cmake build system"
href="https://bugs.webkit.org/show_bug.cgi?id=144561">bug 144561</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>I think the option should be defined with WEBKIT_OPTION_DEFINE in PlatformGTK.cmake, off by default and private (invisible/unsupported). The option should have appropriate conflicts on ENABLE_WAYLAND_TARGET or ENABLE_X11_TARGET as needed.
(In reply to <a href="show_bug.cgi?id=144561#c5">comment #5</a>)
<span class="quote">> Here you should give an error, because we want the build to produce errors
> instead of silently disabling things now.</span >
Well, it should be an error indeed, but in PlatformGTK.cmake, not there. The find module shouldn't have anything to do with which features to enable: it should just find things. It should export a variable, say GTK_QUARTZ_FOUND, to indicate if it is available. Then in PlatformGTK.cmake, if ENABLE_QUARTZ_TARGET is set but GTK_QUARTZ_FOUND is not, the build should fail using message(FATAL_ERROR ...).
But this patch is only copying the existing format of FindGTK3.cmake, which touches both ENABLE_X11_TARGET and ENABLE_WAYLAND_TARGET currently. I didn't realize it was doing that (since it is just a find module and I didn't anticipate it having side effects). Anyway, that won't work as expected anymore since this code runs after the values of those settings have already gone into the FEATURE_DEFINES list, so you would wind up with e.g. ENABLE_X11_TARGET turned off for most of the build, but on in IDL files (which use FEATURE_DEFINES). (I think ENABLE_QUARTZ_TARGET doesn't make it into FEATURE_DEFINES at all, since it's not defined with WEBKIT_OPTION_DEFINE.) I should file another bug for that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>