<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] Unify platform display handling"
href="https://bugs.webkit.org/show_bug.cgi?id=144517#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] Unify platform display handling"
href="https://bugs.webkit.org/show_bug.cgi?id=144517">bug 144517</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252223&action=diff" name="attach_252223" title="Patch">attachment 252223</a> <a href="attachment.cgi?id=252223&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252223&action=review">https://bugs.webkit.org/attachment.cgi?id=252223&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/PlatformDisplay.cpp:49
> +PlatformDisplay* PlatformDisplay::createPlatformDisplay()</span >
Any reason why this doesn't use std::make_unique<>() and return a std::unique_ptr<>?
<span class="quote">> Source/WebCore/platform/graphics/PlatformDisplay.cpp:77
> +std::unique_ptr<PlatformDisplay> PlatformDisplay::s_sharedDisplay;</span >
I'd prefer this moved off the class and into the PlatformDisplay::sharedDisplay() method.
Perhaps it would be wise to also use std::call_once(), given that in the future this might be accessed from multiple threads.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>