<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] Unify platform display handling"
href="https://bugs.webkit.org/show_bug.cgi?id=144517">bug 144517</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252223 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] Unify platform display handling"
href="https://bugs.webkit.org/show_bug.cgi?id=144517#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] Unify platform display handling"
href="https://bugs.webkit.org/show_bug.cgi?id=144517">bug 144517</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252223&action=diff" name="attach_252223" title="Patch">attachment 252223</a> <a href="attachment.cgi?id=252223&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252223&action=review">https://bugs.webkit.org/attachment.cgi?id=252223&action=review</a>
Excellent clean up.
<span class="quote">> Source/WebCore/platform/graphics/PlatformDisplay.h:65
> +#define SPECIALIZE_TYPE_TRAITS_PLATFORM_DISPLAY(ToClassName, DisplayType) \
> +SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::ToClassName) \
> + static bool isType(const WebCore::PlatformDisplay& display) { return display.type() == WebCore::PlatformDisplay::Type::DisplayType; } \
> +SPECIALIZE_TYPE_TRAITS_END()</span >
This is cool.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:242
> #if PLATFORM(X11)
> - Display* display = GLContext::sharedX11Display();
> - m_glDisplay = GST_GL_DISPLAY(gst_gl_display_x11_new_with_display(display));
> + m_glDisplay = GST_GL_DISPLAY(gst_gl_display_x11_new_with_display(downcast<PlatformDisplayX11>(sharedDisplay).native()));
> #elif PLATFORM(WAYLAND)
> - EGLDisplay display = WaylandDisplay::instance()->eglDisplay();
> - m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(display));
> + m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayWayland>(sharedDisplay).native()));
> #endif</span >
These are #ifs but they really should both co-exist. It's unrelated to this patch though.
<span class="quote">> Source/WebCore/platform/graphics/surfaces/glx/X11Helper.cpp:317
> {
> - // Display connection will only be broken at program shutdown.
> - static DisplayConnection displayConnection;
> - return displayConnection.display();
> + return downcast<PlatformDisplayX11>(PlatformDisplay::sharedDisplay()).native();</span >
Maybe these helpers can gradually move into PlatformDisplayX11.
<span class="quote">> Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.h:36
> +#include <wayland-client.h>
> +
> +#include <wayland-egl.h></span >
Nit: Extra empty line here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>