<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent"
href="https://bugs.webkit.org/show_bug.cgi?id=144489#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent"
href="https://bugs.webkit.org/show_bug.cgi?id=144489">bug 144489</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252192&action=diff" name="attach_252192" title="patch">attachment 252192</a> <a href="attachment.cgi?id=252192&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252192&action=review">https://bugs.webkit.org/attachment.cgi?id=252192&action=review</a>
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.h:202
> - void setTextSelectionIntent(AXTextStateChangeIntent);
> + void setTextSelectionIntent(AXTextStateChangeIntent, bool isSynchronizing = false);</span >
When callers are all passing constants to a boolean in a case like this, the WebKit project tradition is to either use two functions (which seems like the right solution in this case) so the names of the functions can make it clear what the difference is, or to use an enum so the names of the constants can make that clear.
Since every single caller uses a boolean, I suggest two separate named functions rather than a function with an optional boolean argument.
I also suggest changing this function to take const AXStateChangeIntent& since that would be slightly more efficient; not sure why this passes by value instead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>