<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Function allocation sinking shouldn't be performed on singleton functions"
href="https://bugs.webkit.org/show_bug.cgi?id=144166#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Function allocation sinking shouldn't be performed on singleton functions"
href="https://bugs.webkit.org/show_bug.cgi?id=144166">bug 144166</a>
from <span class="vcard"><a class="email" href="mailto:basile_clement@apple.com" title="Basile Clement <basile_clement@apple.com>"> <span class="fn">Basile Clement</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144166#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=251587&action=diff" name="attach_251587" title="Fix ChangeLog typos">attachment 251587</a> <a href="attachment.cgi?id=251587&action=edit" title="Fix ChangeLog typos">[details]</a></span>
> Fix ChangeLog typos
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=251587&action=review">https://bugs.webkit.org/attachment.cgi?id=251587&action=review</a>
>
> Holding off cq because the ChangeLog comment could be refined.
>
> > Source/JavaScriptCore/ChangeLog:14
> > + watchpoints invalidating code that depends on it being a singleton). According
> > + to fpizlo, this happens to be sinkable right now, but things may not stay that
> > + way in the future (e.g. it would not be the case for CreateActivation), and
> > + fixing this now would help prevent hard-to-find bugs later in that case.
>
> What won't stay that way in the future? That singleton function allocations
> are sinkable?
>
> I think it's enough to say that we don't want to sink code that has effects
> if we haven't done the work to prove that the effect wasn't observed.
> Object allocation sinking phase does no such analysis because it assumes
> that the act of allocating is not effectful.</span >
OK, will simplify that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>