<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Function allocation sinking shouldn't be performed on singleton functions"
href="https://bugs.webkit.org/show_bug.cgi?id=144166">bug 144166</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #251587 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Function allocation sinking shouldn't be performed on singleton functions"
href="https://bugs.webkit.org/show_bug.cgi?id=144166#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Function allocation sinking shouldn't be performed on singleton functions"
href="https://bugs.webkit.org/show_bug.cgi?id=144166">bug 144166</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251587&action=diff" name="attach_251587" title="Fix ChangeLog typos">attachment 251587</a> <a href="attachment.cgi?id=251587&action=edit" title="Fix ChangeLog typos">[details]</a></span>
Fix ChangeLog typos
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251587&action=review">https://bugs.webkit.org/attachment.cgi?id=251587&action=review</a>
Holding off cq because the ChangeLog comment could be refined.
<span class="quote">> Source/JavaScriptCore/ChangeLog:14
> + watchpoints invalidating code that depends on it being a singleton). According
> + to fpizlo, this happens to be sinkable right now, but things may not stay that
> + way in the future (e.g. it would not be the case for CreateActivation), and
> + fixing this now would help prevent hard-to-find bugs later in that case.</span >
What won't stay that way in the future? That singleton function allocations are sinkable?
I think it's enough to say that we don't want to sink code that has effects if we haven't done the work to prove that the effect wasn't observed. Object allocation sinking phase does no such analysis because it assumes that the act of allocating is not effectful.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>